FS#5268 - The elder refit bug

Attached to Project: OpenTTD
Opened by akasoft (akasoft) - Thursday, 09 August 2012, 08:32 GMT
Last edited by frosch (frosch) - Thursday, 09 August 2012, 19:10 GMT
Type Bug
Category Vehicles
Status Closed
Assigned To No-one
Operating System Windows
Severity Medium
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 3
  • Serg Stepanov (GhostRybinsk) (2012-09-16)
  • Serge (trtycoon) (2012-09-15)
  • akasoft (akasoft) (2012-08-09)
Private No


Start game on 1964, using cheats buy 2TE10 locomotive (train 1) and 2TE10L (train 2). On tab Capacities can see default livery: both "Capacity: None (livery 1)". Train 1 has 3 possible liveries ([0, 1, 2]), train 2 - only 2 ([0, 1]). (screenshot rb1.png)

Attach train 2 to train 1. We can see all 3 the livery in the Refit window. Select "livery 3" and refit to. (screenshot rb2.png)

We can see result on 2TE10L at the mouse pointer: "Capacity: None" instead "Capacity: None (livery 3)" like 2TE10 above.
2TE10L has no livery 3, but variable cargo_subtype (NML) is changet previus value (0) to 2 while valid range is [0, 1] for the 2TE10L. (screenshot rb3.png)

Expected: 2TE10 change livery to the livery 3, 2TE10L not changed livery and stay on the livery 1.

Next, buy the 'Luggage car 20,2m'. He had 3 livery ([0, 1, 2]) and 2 possible cargos. Attach it to train 1. (screenshot rb4.png)
And then refit all to "Goods (Red Arrow)". Result on screenshot rb5.png. the 'Luggage car 20,2m' has changed the livery. Good. But locomotives has changed livery too, both to livery 2!

Expected: car with same ID changes livery, locomotive (other ID) - not.

Screenshots, grf and savegame are attached.

I think, this is the bug.
Or still feature? :)

windows x64, openttd trunk 24459, grf build with NML r1966 (c8088e3c6e83).
   rb1.png (342 KiB)
   rb2.png (342.3 KiB)
   rb3.png (342.2 KiB)
   rb4.png (344.8 KiB)
   rb5.png (354.8 KiB)
(application/octet-stream)    xussr.grf (6.11 MiB)
(application/octet-stream)    rb_bug.sav (24.4 KiB)
(application/octet-stream)    rb_bug_2.sav (24.4 KiB)
This task depends upon

Closed by  frosch (frosch)
Thursday, 09 August 2012, 19:10 GMT
Reason for closing:  Duplicate
Additional comments about closing:  of FS#3764
Comment by akasoft (akasoft) - Thursday, 09 August 2012, 08:42 GMT
When apply the livery to the vehicle should be compared texts, rather than numbers. To get a list of the vehicles, which can be applied the livery.