Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not saving "apply" settings #5247

Closed
DorpsGek opened this issue Jul 16, 2012 · 6 comments
Closed

Not saving "apply" settings #5247

DorpsGek opened this issue Jul 16, 2012 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Moriarty opened the ticket and wrote:

While testing http://bugs.openttd.org/task/5245 I removed the NewGRF's that were active then clicked "apply". I then proceeded to make the game crash as described. When I restarted the game the NewGRF's that I had removed were back on the list of being active. Even if I click apply, close the NewGRF screen, the re-open the screen to confirm they're gone (they are), then proceed to make it crash, the NewGRFs are back on there after the crash.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5247
@DorpsGek
Copy link
Member Author

frosch wrote:

OpenTTD saves settings only on exit.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247#comment11387

@DorpsGek
Copy link
Member Author

frosch closed the ticket.

Reason for closing: Not a bug

by design


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247

@DorpsGek
Copy link
Member Author

Alberth wrote:

Note that while a crash also ends the program, it is not considered to be an 'exit', so the settings are not saved on a crash.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247#comment11388

@DorpsGek
Copy link
Member Author

Moriarty wrote:

I think this is very VERY bad design. I'm sure I've had issues with this before too. Its totally not intuitive. If the game is showing the settings as being saved (i.e., you exit the menu and re-enter it), then its totally incongruous to find out that actually they weren't saved anywhere other than in RAM.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247#comment11413

@DorpsGek
Copy link
Member Author

frosch wrote:

I think this is very clever design. If you change something which causes the game to crash (e.g. fullscreen or resolution or similiar), you can easily revert back to the old working settings.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247#comment11417

@DorpsGek
Copy link
Member Author

Moriarty wrote:

Yes, in that sole instance its a good thing. In every other use case (including the real-world one that actually happened above, plus countless other times this has bitten me), its a bad thing.
If you're concerned about resolution breaking things, do what other games and even Operating Systems do - offer up a "are you sure you want to save these settings" once the user has changed to that resolution. But don't inconvenience and confuse all of the players for a single, rare use-case.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5247#comment11423

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant