FS#5236 - View DLC Textfiles

Attached to Project: OpenTTD
Opened by Charles Pigott (LordAro) - Friday, 06 July 2012, 20:21 GMT
Last edited by Thijs Marinussen (Yexo) - Monday, 20 August 2012, 21:05 GMT
Type Patch
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Medium
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


As per Todo List :)

Code review please :P
This task depends upon

Closed by  Thijs Marinussen (Yexo)
Monday, 20 August 2012, 21:05 GMT
Reason for closing:  Implemented
Additional comments about closing:  In r24487 / r24488
Comment by Charles Pigott (LordAro) - Saturday, 07 July 2012, 17:23 GMT
Update, split into more patches, and implement Zuu's bug report fixes

hg patch queue, for r24376
Comment by Thijs Marinussen (Yexo) - Monday, 13 August 2012, 19:15 GMT
I just committed the first 2 patched. The 3rd patch still has some issues:
- HasBaseSet: The name implies it returns a boolean, which is previously did. If you change the return value to a string you should update the name accordingly.
- ScriptScanner::FindScript: documentation mentions "find a script", "@return A filename of a file of the content": this is not explicit enough. It finds the main script (main.nut), not a random filename. I think a better function name is something like GetMainScript (that already exists, but this function services the same purpose).
Comment by Charles Pigott (LordAro) - Tuesday, 14 August 2012, 21:51 GMT
done, although i just found a seg fault situation, which i shall attempt to rectify before re-submitting the patch
(If you have an item of content selected for download, then download it while still selecting it, a seg fault occurs in ContentInfo::GetTextfile - i you want to take a look ;) )
(in patch #04)
Comment by Charles Pigott (LordAro) - Thursday, 16 August 2012, 20:45 GMT

now against r24477 (if that matters too much)

and with added bonus patch :)
Comment by Charles Pigott (LordAro) - Monday, 20 August 2012, 20:48 GMT
fixed 04_* patch: