Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise max loaded NewGRF limit #5117

Closed
DorpsGek opened this issue Mar 21, 2012 · 7 comments
Closed

Raise max loaded NewGRF limit #5117

DorpsGek opened this issue Mar 21, 2012 · 7 comments
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Supercheese opened the ticket and wrote:

Currently (as of r24054), there is be a limit of 63 NewGRFs that can be loaded at once. If you try and load more than this, OTTD throws a Fatal Error.

I, for one, see no reason why it should be at such a low level, and I would very much like to see it raised. I do hope there aren't any hidden reasons why raising this limit would cause problems...

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5117
@DorpsGek
Copy link
Member Author

Supercheese wrote:

Please pardon the typo; I was going back and forth between "there seems to be" and "there is", resulting in "there is be"...


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment11002

@DorpsGek
Copy link
Member Author

PaulC wrote:

Hmm, the limit actually seems to 59 (at least, it is for me). One could argue that 59 (or 63) is more than sufficient for anyone, but (and bearing in mind that not all grfs are equal) why do we need a limit at all?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment11011

@DorpsGek
Copy link
Member Author

frosch wrote:

For the multiplayer lobby all used NewGRFs must be put into a single UDP packet.
A UDP packet is very limited in size.


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment11014

@DorpsGek
Copy link
Member Author

PaulC wrote:

Well I don't know about that, but as I said not all grfs are equal (in size) so I don't necessarily see how a limit on the number of grfs is useful. I'm really thinking about offline single player, which I assume is the majority of users?


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment11015

@DorpsGek
Copy link
Member Author

dihedral wrote:

The UDP Packets contain the grfid and the md5sum of the grf - not the grf itself. Hence the actual size of the grf is not of interest at this point ;-)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment11040

@DorpsGek
Copy link
Member Author

andythenorth wrote:

Anyone who wants that many grfs should implement it for themselves. Issue should be closed. :)


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117#comment14341

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

[11:41pm] Supercheese: yeah, There's a Patch for That™
[11:41pm] Supercheese: and that's good enough for me


This comment was imported from FlySpray: https://bugs.openttd.org/task/5117

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) component: NewGRF This issue is related to NewGRFs enhancement labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: NewGRF This issue is related to NewGRFs flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant