FS#509 - Simplify GetTransportedGoodsIncome

Attached to Project: OpenTTD
Opened by rfalke (rfalke) - Wednesday, 03 January 2007, 13:31 GMT
Type Patch
Category Core
Status Closed
Assigned To Jean-Francois Claeys (Belugas)
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The attached patch simplifies the function economy.c:GetTransportedGoodsIncome.
Previously it was hard to understand for outsiders.
This task depends upon

Closed by  Remko Bijker (Rubidium)
Wednesday, 25 July 2007, 19:29 GMT
Reason for closing:  Implemented
Additional comments about closing:  In r10691.
Comment by Jean-Francois Claeys (Belugas) - Saturday, 17 March 2007, 00:16 GMT
you have replaced one byte by 3 int, used 3 times the magic number 255 instead of one, used spaces instead of tabs.
You may seems to have understood what the function does, but you did not wrote a single comment.
Sorry, but... maybe some more work?
Thanks anyway
Comment by rfalke (rfalke) - Monday, 19 March 2007, 19:08 GMT
I new updated patch with extended comments.
Comment by Jean-Francois Claeys (Belugas) - Tuesday, 20 March 2007, 19:26 GMT
Much better!
I even can undertand it myself now ;)