Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify GetTransportedGoodsIncome #509

Closed
DorpsGek opened this issue Jan 3, 2007 · 4 comments
Closed

Simplify GetTransportedGoodsIncome #509

DorpsGek opened this issue Jan 3, 2007 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 3, 2007

rfalke opened the ticket and wrote:

The attached patch simplifies the function economy.c:GetTransportedGoodsIncome.
Previously it was hard to understand for outsiders.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/509
@DorpsGek
Copy link
Member Author

Belugas wrote:

you have replaced one byte by 3 int, used 3 times the magic number 255 instead of one, used spaces instead of tabs.
You may seems to have understood what the function does, but you did not wrote a single comment.
Sorry, but... maybe some more work?
Thanks anyway

This comment was imported from FlySpray: https://bugs.openttd.org/task/509#comment1078

@DorpsGek
Copy link
Member Author

rfalke wrote:

I new updated patch with extended comments.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/509#comment1090

@DorpsGek
Copy link
Member Author

Belugas wrote:

Much better!
I even can undertand it myself now ;)

This comment was imported from FlySpray: https://bugs.openttd.org/task/509#comment1091

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r10691.

This comment was imported from FlySpray: https://bugs.openttd.org/task/509

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek