Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View GS/AI textfiles #5047

Closed
DorpsGek opened this issue Feb 5, 2012 · 4 comments
Closed

View GS/AI textfiles #5047

DorpsGek opened this issue Feb 5, 2012 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Feb 5, 2012

LordAro opened the ticket and wrote:

Hello

I (with the usual lots of help from Alberth) have created a patch that allows you to view readmes/changelogs/licences of AIs and Gamescripts

Feedback (+ trunk inclusion ;P ) appreciated

(patch against r23903)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/5047
@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 6, 2012

Rubidium wrote:

Overall the patch does not look bad. However, it's a bit big and we rather see patches in smaller more logical chunks. For example a first patch would be splitting the NewGRF and Window code (without renaming the strings), then one that renames/changes the way the strings are constructed, followed by one that moves/generalises the "find file" algorithm and then finally a patch that introduces the text files to GS/AI scripts.

One note though; the following looks weird, although not incorrect.
+ (slot == OWNER_DEITY) ? this->LoadTextfile(textfile, GAME_DIR) : this->LoadTextfile(textfile, AI_DIR);
+ (slot == OWNER_DEITY) ? SetDParam(0, STR_CONTENT_TYPE_GAME_SCRIPT) : SetDParam(0, STR_CONTENT_TYPE_AI);
I would however be preferred to write it respectively:
+ this->LoadTextfile(textfile, slot == OWNER_DEITY ? GAME_DIR : AI_DIR);
+ SetDParam(0, slot == OWNER_DEITY ? STR_CONTENT_TYPE_GAME_SCRIPT : STR_CONTENT_TYPE_AI);


This comment was imported from FlySpray: https://bugs.openttd.org/task/5047#comment10877

@DorpsGek
Copy link
Member Author

LordAro wrote:

I believe i have satisfied to 2 previous requests:

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/5047#comment10883

@DorpsGek
Copy link
Member Author

Terkhen wrote:

Patch 25 has some rejects that should be fixed. I get an error while trying to compile the whole queue (the error is introduced at 40):

http://paste.openttdcoop.org/show/1097/


This comment was imported from FlySpray: https://bugs.openttd.org/task/5047#comment10887

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

Around r23933


This comment was imported from FlySpray: https://bugs.openttd.org/task/5047

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant