Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players can block servers forever #4955

Closed
DorpsGek opened this issue Jan 6, 2012 · 2 comments
Closed

Players can block servers forever #4955

DorpsGek opened this issue Jan 6, 2012 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 6, 2012

xOR opened the ticket and wrote:

The critical section here is the map download. There is no timeout for players downloading the map, yet the server is already paused and not letting any other new players in. So if a player has a broken, overloaded or just very poor Internet connection and takes 10 minutes to download the map this won't let any other players in for 10 minutese. As pause-on-join is enabled by default on many servers this will also prevent the players on it from playing during that time - most probably scaring them off and making them leave the server.

What's worse, a player can also actively exploit this by never finishing the map download on purpose. Most probably it would be possible to write a small program that can do this automatically and could be used to block any public OpenTTD server out there, but that is not even necessary. Players can even use the vanilla OpenTTD client if they are on Windows (tested on Windows 7 x64 Ultimate as well as Windows XP Prof. SP3): simply start connecting with OpenTTD in windowed mode and during the map download do a right click on the border of the OpenTTD window. This will bring up the Windows context menu but as a side-effect also freeze OpenTTD. Now the player can just lean back and wait, knowing that nobody else on the server can't play anymore and no new players are allowed in. Unless an admin is noticing it and kicking the player.

Reported version: 1.1.4
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4955
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2012

xOR wrote:

We just tried it, the attachment shows what players that try to join the "blocked" server are seeing.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4955#comment10687

@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 6, 2012

Rubidium closed the ticket.

Reason for closing: Fixed

In r23764


This comment was imported from FlySpray: https://bugs.openttd.org/task/4955

@DorpsGek DorpsGek closed this as completed Jan 6, 2012
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Network labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant