FS#4953 - Orders: creating Transfer + Refit + Load orders could be made easier

Attached to Project: OpenTTD
Opened by Leif Linse (Zuu) - Friday, 06 January 2012, 00:03 GMT
Last edited by andythenorth (andythenorth) - Sunday, 20 August 2017, 18:08 GMT
Type Feature Request
Category Vehicles
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


With the addition of refit at station orders it now can make sense to have both Transfer + Load as order for the same station if the train also refits there.

== Proposal ==
I propose that if you select Transfer and the order item already has a Full Load or Full Load Any order, then don't default to No Load. Only when the order has no specific load order, default to No Load.

== Consequence if not fixed ==
If this change is not made, it is still possible to create Transfer + Refit + Full Load (Any) if you make sure to give the transfer order before the full load order.
This task depends upon

Closed by  andythenorth (andythenorth)
Sunday, 20 August 2017, 18:08 GMT
Reason for closing:  Won't implement
Additional comments about closing:  I discussed this with Zuu, and he's happy with it being closed as part of Flyspray clean up.
Comment by Leif Linse (Zuu) - Friday, 06 January 2012, 00:04 GMT
Also, it might be wise to not clean the refit order when applying the transfer order regardless if the load order is changed or not.
Comment by Remko Bijker (Rubidium) - Friday, 06 January 2012, 22:00 GMT
If you force unloading (unload or transfer) with articulated vehicles then this order will cause the same cargo to be reloaded under certain circumstances.

E.g. a two part articulated vehicle, front part 100% loaded, tail part 50% loaded. Upon unloading cargo is unloaded at a steady rate, so when the tail part reached 50% the front part is 50% loaded. Then the tail thinks about refitting, but it can't because it isn't empty. It will then happily continue the (full) loading order. At a moment the front part reached 0% loaded, but the tail part is already 50% loaded so it won't be able to refit there either. In the end all the unloaded cargo will be loaded back into the vehicle.

So I'd actually propose disallowing loading or unloading when refitting at a station as that can give unwanted side effects, such as not refitting at all.
Comment by Leif Linse (Zuu) - Tuesday, 05 February 2013, 23:32 GMT
I had though that it would work something like this:

1) Start unload/transfer
2) Wait until no wagon / articulated part is unloading/transfering anymore
3) Stop unload/transfer [if that is needed so that no part decide to start unloading later because station acceptance changing]
4) Refit
5) Start loading
6) Wait for loading to stop
7) Departure

However, from your explanation, I see that my idea of how my order was executed is wrong. To not have the problems that you clearly shown, either the availability of a refit order need to trigger a special (slower) unload/load process where unload and load is separated like above, or a restriction is added like you have proposed to not allow orders with load/unload and refit at the same order.