Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameters for fatal NewGRF message not properly used #4599

Closed
DorpsGek opened this issue Apr 23, 2011 · 2 comments
Closed

Parameters for fatal NewGRF message not properly used #4599

DorpsGek opened this issue Apr 23, 2011 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

Custom NewGRF error messages (0xFF) don't use the STRING parameters properly, instead OpenTTD generates the output
dbg: [grf] Unknown StringID 0xFFFF remapped to STR_EMPTY. Please open a Feature Request if you need it

Test case: OpenGFX+ Industries and Pikka's Basic Industries used jointly will generate it.

[23:49] Yexo planetmaker: after a lot of recompiling I can't trigger that bug anymore
[23:49] Yexo if you can still reproduce the " is incompatible with ." bug please open a bug at fs so I don't forget to look at it
[23:51] planetmaker hm... I get it everytime. You have with ogfx+industries head now a test case
[23:51] planetmaker actually... once with the agricultural vector of ECS I even got "Food processing plant is incompatible with ."
[23:52] planetmaker dbg: [grf] Unknown StringID 0xFFFF remapped to STR_EMPTY. Please open a Feature Request if you need it <-- console
[00:00] Yexo that is even reproducible in 1.1.0 :(

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4599
@DorpsGek
Copy link
Member Author

Yexo wrote:

The problem is in ErrmsgWindow, it doesn't call SwitchToErrorRefStack often enough. There might be more related problems in that class, since I'm not sure if SwitchToNormalRefStack is always called before leaving code related to this class. The exact effects of leaving out the call to SwitchToNormalRefStack are unclear to me at the moment.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4599#comment9894

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 3, 2011

frosch closed the ticket.

Reason for closing: Fixed

in r22629

This comment was imported from FlySpray: https://bugs.openttd.org/task/4599

@DorpsGek DorpsGek closed this as completed Jul 3, 2011
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek