Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (r19397): starting year not set in scenario editor by clicking at the date panel #4188

Closed
DorpsGek opened this issue Oct 28, 2010 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

sbr opened the ticket and wrote:

In the scenario editor, changing the starting year by clicking at the date panel don't change the starting year of the scenario file.

To reproduce it:
- open the scenario editor, create a town
- change the starting year by clicking at the date panel, don't use the backward/forward buttons.
- save scenario and load it from main menu: the game don't start at the expected year.

Using the backward/forward buttons doesn't reproduce this behavior as they call "SetDate(...)" to update the starting year.
I think that the "OnQueryTextFinished(...)" method of the date panel should also call "SetDate(...)" to properly set the new starting year.

Also the query window was filled with "_settings_newgame.game_creation.starting_year" where it should be "_settings_game.game_creation.starting_year".

Please find attached a patch against r21051.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4188
@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Fixed

Thanks for the patch. Sorry for not mentioning you in the commit message, your work is appreciated.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4188

@DorpsGek
Copy link
Member Author

Yexo wrote:

In r21054.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4188#comment8992

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant