sbr opened the ticket and wrote:

Before the introduction of VehicleListIdentifier, the window owner was extracted from window_number ('GB(this->window_number, 0, 8)') in the group GUI. This was used in the constructor but also in the 'SetStringParameters(int)' method to set the window title.

The 'SetStringParameters(int)' method wasn't updated in r20772 and always try to get the owner from the window number. This results in, other than first, companies having group GUI title set to the first company name. Also crashing the game when the first company gone bankrupt and therefore doesn't exists anymore.

The owner could be obtained from 'this->owner' or 'this->vli.company'. As 'SetStringParameters(int)' is first called during 'FinishInitNested(WindowDesc, WindowNumber)', that is when 'this->owner' isn't set (cf. r20781), 'this->vli.company' should be used to reliably obtain the owner of the window.

Please find attached a patch against r20890.

Attachments

• fix-group-window-title_hg-b570bcf795b6.patch (0.52 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/4148