FS#4121 - Too easy to "accidentally" overwrite a saved game

Attached to Project: OpenTTD
Opened by Ralph (RAC93) - Sunday, 12 September 2010, 16:10 GMT
Last edited by andythenorth (andythenorth) - Saturday, 02 September 2017, 12:06 GMT
Type Patch
Category Interface
Status Closed
Assigned To No-one
Operating System Windows
Severity Medium
Priority Normal
Reported Version other
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


Hi. At times, I find myself accidentally overwriting
a saved game when I'm actually trying to load it.

Can an "optional" warning could be added when you are
about to overwrite a saved game?

There should be an option on the menu to enable it,
as some people are probably fine with the existing
"no warning".
This task depends upon

Closed by  andythenorth (andythenorth)
Saturday, 02 September 2017, 12:06 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Flyspray clean up, no way forward for this, not a current OpenTTD goal, so closing. Thanks.
Comment by Jean-Francois Claeys (Belugas) - Monday, 13 September 2010, 01:58 GMT
Well... given that every time you save the game, there is a new name been provided, it means that you have voluntary choose an already existing one.
So... hom much protection against yourself would you need???
Comment by frosch (frosch) - Monday, 13 September 2010, 16:19 GMT
I think it is about confusing the save and the load window.
However, you can load a game with doubleclick, but saving requires clicking the button.
Comment by Matt D. (monoid) - Monday, 29 August 2011, 15:25 GMT
I think there should always be an explicit confirmation from the user before doing anything as irrevocable as overwriting a saved file. I don't agree, however, that it needs to be optional via a setting.

This patch implements such a confirmation.
Comment by andythenorth (andythenorth) - Monday, 21 August 2017, 08:14 GMT
Patch fails to apply on r27895. I'm not convinced we need this fix, but as the patch is provided, I thought I'd test it. Fixing it might be TMWFTLB.

(Stripping trailing CRs from patch.)
patching file src/fios_gui.cpp
Hunk #1 FAILED at 239.
Hunk #2 FAILED at 670.
2 out of 2 hunks FAILED -- saving rejects to file src/fios_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/lang/english.txt
Hunk #1 succeeded at 2715 (offset 412 lines).
openttd-trunk(master)$ ma
openttd-trunk(master)$ git log -l 1