Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dithering in palette file #4079

Closed
DorpsGek opened this issue Aug 25, 2010 · 8 comments
Closed

Dithering in palette file #4079

DorpsGek opened this issue Aug 25, 2010 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

TruePikachu opened the ticket and wrote:

Looking at the file /docs/ottd-colour-palette.gif , I found all kinds of problems, especially with dithering in some blocks (like 123, for instance). Additionally, there has been a plan to convert the game to use the DOS palette instead of the Windows palette according to IRC. I have created two replacement files for the file mentioned above. One of these files are for the Windows palette, and the other is for the DOS palette. Changes from the above mentioned file (excluding the color changes for DOS):
* Dither problems fixed (they were caused by the hovering text)
* GIF palette has been re-indexed, so color 'n' on file is color 'n' in game
* Animation removed. It most likely would add more colors onto the palette, surpassing the 256 color limit.
* Outer pixel border removed - it was not part of the 'window', but part of the 'game'
Problems:
* GIMP apparently didn't like what I was doing, so each cell in the image will not necessairily give the correct color index, but should yield the correct color. However, they are still labeled in the image
The colors selected were from the image located at http://wiki.ttdpatch.net/img/wiki_up/TTD%20Palettes.png .

Reported version: 1.0.3
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/4079
@DorpsGek
Copy link
Member Author

TruePikachu wrote:

The files didn't attach for some reason -_-

EDIT: some indicies on the DOS are messed up, and I'm too lazy to fix right now

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8635

@DorpsGek
Copy link
Member Author

LordAro wrote:

the animation is there for a reason
the oil refinery fire for example


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8641

@DorpsGek
Copy link
Member Author

Rubidium wrote:

I agree, the animation is 99% of the value of that gif; it gives you a clue what are special colours and which aren't.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8649

@DorpsGek
Copy link
Member Author

TruePikachu wrote:

However, the game uses 256 colors in it's pallete, the same as the maximum number of colors in a .gif file, so I guess that the animations can be a seperate file containing ONLY the animations


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8768

@DorpsGek
Copy link
Member Author

Rubidium wrote:

The total number of colours needed for the animation fits within the 256 palette colours, so there is absolutely no reason to split stuff up.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8776

@DorpsGek
Copy link
Member Author

TruePikachu wrote:

It didn't look that way to me...Anyway, why don't you change it then? It's just a .gif file...I don't even have the DOS one set up correctly...


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8777

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Because fixing actual bugs and my real life are more important to me than these stupid animated gifs that apparantly nobody has really looked at besides you.

Especially as fixing this means regenerating the images from scratch which means writing the code to actually make that window and that takes quite a bit of time which I can't be bothered spending on it right now or any time soon.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079#comment8780

@DorpsGek
Copy link
Member Author

Yexo closed the ticket.

Reason for closing: Fixed

Since r20811 there is no broken file anymore.


This comment was imported from FlySpray: https://bugs.openttd.org/task/4079

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant