Alberth wrote:

The crash happens when drawing the vehicles in the buy vehicle window (trunk r20415).

As the screenshot shows, the Hereford Leopard bus, and the Foster bus have a weird size.

After adding some debugging output in src/roadveh_cmd.cpp, around line 152:

- preferred_x = Clamp(preferred_x, left - real_sprite->x_offs, right - real_sprite->width - real_sprite->x_offs);
+ fprintf(stderr, "a=%d, min=%d, max=%d (left=%d, right=%d, x_offs=%d, width=%d\n", preferred_x, left - real_sprite->x_offs, right - real_sprite->width - real_sprite->x_offs, left, right, real_sprite->x_offs, real_sprite->width);
+
+ if (left <= right - real_sprite->width) preferred_x = Clamp(preferred_x, left - real_sprite->x_offs, right - real_sprite->width - real_sprite->x_offs);
+ else preferred_x = left - real_sprite->x_offs;
+

Outputs:
a=31, min=16, max=211 (left=2, right=225, x_offs=-14, width=28
a=31, min=2, max=-359 (left=2, right=225, x_offs=0, width=584
a=31, min=2, max=-359 (left=2, right=225, x_offs=0, width=584
a=31, min=16, max=211 (left=2, right=225, x_offs=-14, width=28
(and more of the last line)

Attachments

• fs4016_bussize.png (25.58 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/4016#comment8486

Alberth closed the ticket.

Reason for closing: Duplicate

of #3683, NewGRF "ECS Construction vector beta 5 (04 Apr 2009)" is broken. Upgrade to a newer one.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4016

ABCRic wrote:

NewGRF "ECS Construction vector beta 5 (04 Apr 2009)" is broken. Upgrade to a newer one.

That NewGRF is not in the list, nor was being used.
Nevertheless, I changed all the ECS GRFs to the updated ones, and now the problem does not occur.
Thanks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/4016#comment8488