Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static building fix for Mac OS X #3972

Closed
DorpsGek opened this issue Jul 24, 2010 · 3 comments
Closed

Static building fix for Mac OS X #3972

DorpsGek opened this issue Jul 24, 2010 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

fmauNeko opened the ticket and wrote:

This is a patch for the building really static binaries on Mac OS X. It fixes the detection of static libraries for lzo2, zlib and iconv, which were always dynamically linked, even if ./configure was called with --enable-static.

Attachments

Reported version: trunk
Operating system: Mac OS X

This issue was imported from FlySpray: https://bugs.openttd.org/task/3972
@DorpsGek
Copy link
Member Author

fmauNeko wrote:

I forgot to precise, this patch is against rev20214.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3972#comment8392

@DorpsGek
Copy link
Member Author

michi_cc wrote:

iconv and zlib are supplied by the OS in any non-ancient version which means they shouldn't be statically linked without a very good reason. (Apple doesn't even ship static libs for these as far as I know.)

This comment was imported from FlySpray: https://bugs.openttd.org/task/3972#comment8393

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Won't implement

Linking statically to stuff that is always available on a system is pointless and just adds extra unneeded vulnerabilities to the OpenTTD binaries.

This comment was imported from FlySpray: https://bugs.openttd.org/task/3972

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek