Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it's possible to join server without knowing server password #3754

Closed
DorpsGek opened this issue Apr 11, 2010 · 2 comments
Closed

it's possible to join server without knowing server password #3754

DorpsGek opened this issue Apr 11, 2010 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

SmatZ opened the ticket and wrote:

The problem is in DEF_SERVER_RECEIVE_COMMAND(PACKET_CLIENT_PASSWORD)...
maybe we should split STATUS_AUTHORIZING to STATUS_AUTHORIZING_SERVER and STATUS_AUTHORIZING_COMPANY, or so

How to reproduce - with passworded companies:
start server, server password 'XXX'
start new company, company password 'YYY'
join with patched client to the company, password 'YYY' is enough - needs join_server_hack.diff

How to reproduce - with unpassworded companies:
start server, server password 'XXX'
join with patched client to the company - needs join_server_hack_2.diff

Attachments

Reported version: 1.0.0
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/3754
@DorpsGek
Copy link
Member Author

SmatZ wrote:

should be fixed by r19607, let's wait with closing this task


This comment was imported from FlySpray: https://bugs.openttd.org/task/3754#comment7840

@DorpsGek
Copy link
Member Author

SmatZ closed the ticket.

Reason for closing: Fixed

In r19607, needs backporting


This comment was imported from FlySpray: https://bugs.openttd.org/task/3754

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant