Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Face customization to be made more comprehensive #351

Closed
DorpsGek opened this issue Sep 24, 2006 · 7 comments
Closed

Face customization to be made more comprehensive #351

DorpsGek opened this issue Sep 24, 2006 · 7 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

jez9999 opened the ticket and wrote:

You need to apply the .patch file attached to this post then compile for it to work. It works with the latest SVN revision as of the time of this post (rev 6502), although it's changing all the time so who knows in a week.

As you can see in the screenshot it allows extensive face customization, saving/loading of the current face to a config file variable, and a manual view/input of the current 'face code' (a 32 bit unsigned integer controlling the look of the face). It also includes significant rewriting of the face-drawing code (located in players.c) to make the structure of the player face variable more meaningful.

The one very minor bug I know about is:
Click Load or Save, then close the face dialog, leaving the red message dialog open. Open the face dialog again, then click load or save. The button doesn't appear to press in first time, as if SetWindowDirty() hadn't been called.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/351
@DorpsGek
Copy link
Member Author

jez9999 wrote:

The screenshot referenced is the one posted to the TT-Forums, at this URL:
http://www.tt-forums.net/viewtopic.php?t=27545


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment535

@DorpsGek
Copy link
Member Author

jez9999 wrote:

Version 2 of the patch (and screenshot) is attached.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment536

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2006

jez9999 wrote:

Adding latest version of patch, v10.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment582

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 5, 2006

KUDr wrote:

Latest version (DrawPlayerFace() in players.c reworked a bit).
I would like to commit it today if no objections will be thrown after anouncing it on # openttd.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment583

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 6, 2006

KUDr wrote:

The last agreement we have made is, that:

  1. Commit is postponed to after the 0.5.0 release. This is because the current patch breaks the compatibility with the old savegames. Internally it uses different bit layout inside the face code (uint32) variables. So if you load the old savegame into patched version, the face is totally different, than when you load the same savegame into the version without this patch. By other words, this patch is not 0.5 compliant. We must find some way how to solve this bakwards compatibility issue.

  2. The new face customization GUI needs to be reworked a bit. The new part (right side with the arrows and numbers) will be hiden by default and it will only show - pop out to the right, like the station window does to the bottom when 'ratings' are clicked. The left side should look the same as before the patch (except this new button).

  3. The coding style must stay 'ottd compliant'


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment585

@DorpsGek
Copy link
Member Author

DorpsGek commented Mar 8, 2007

Rubidium wrote:

I have changed the bit usage of the face code quite a lot lately. This should solve the first issue (backward compatability). However, the patch is now very outdated and needs some major rewrites. Primarily because most of the wrapper function can be ditched now.


This comment was imported from FlySpray: https://bugs.openttd.org/task/351#comment1022

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 6, 2007

TrueBrain closed the ticket.

Reason for closing: Out of date

Although such a patch would be welcome, this patch is outdated and doesn't seem to get an update any time soon.. closing. If you ever update the patch, feel free to reopen.


This comment was imported from FlySpray: https://bugs.openttd.org/task/351

@DorpsGek DorpsGek closed this as completed Aug 6, 2007
@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
corpulentcoffee pushed a commit to corpulentcoffee/OpenTTD that referenced this issue Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant