Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't treat empty widgets as false positive in CompareWidgetArrays() #2813

Closed
DorpsGek opened this issue Apr 5, 2009 · 3 comments
Closed

Don't treat empty widgets as false positive in CompareWidgetArrays() #2813

DorpsGek opened this issue Apr 5, 2009 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 5, 2009

sbr opened the ticket and wrote:

This patch avoid CompareWidgetArrays() to report empty widget as false positive.

In the original format, empty widget are coded with left == right == top == bottom == 0.
In the nested widgets format, they are defined with SetMinimalSize(0, 0). Converted to the original format, this widget has left == right + 1 and inherit container's top and bottom.
The original widget and the converted nested one thus differ in their definition and are catched by CompareWidgetArrays().

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2813
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2009

Alberth wrote:

Not all WWT_EMPTY widgets have their top-left corner at (0, 0), and size (1, 1).

Rather than sweeping differences under the carpet, a better approach may be to eliminate such widgets (which is what nested widgets aim to do).
CompareWidgetArrays() is just a step towards that goal.

Edit: Clarified last statements.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2813#comment5904

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Will eventually be fixed once the GUI rework is done.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2813#comment6323

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Out of date

Since CompareWidgetArrays has been removed in r18088.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2813

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek