Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load scenario accessible from running game (in save/load menu) #2754

Closed
DorpsGek opened this issue Mar 21, 2009 · 2 comments
Closed

load scenario accessible from running game (in save/load menu) #2754

DorpsGek opened this issue Mar 21, 2009 · 2 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

planetmaker opened the ticket and wrote:

Now that many scenarios are available for easy download, it can be desirable to be able to look at different scenarios and load another from within the game. This patch adds a "load scenario" entry to the save/load menu for GM_NORMAL
Patch is for r15776.

One question improvement can be made to the patch: the string naming
Currently it reads:
STR_015B_OPENTTD :{WHITE}About OpenTTD
STR_015C_SAVE_GAME :Save game
STR_015D_LOAD_GAME :Load game
+STR_015D2_LOAD_SCENARIO :Load scenario
STR_015E_QUIT_GAME :Abandon game
STR_015F_QUIT :Exit

when the strings would be re-named to
...
STR_015E_LOAD_SCENARIO
STR_015F_QUIT_GAME
STR_015G_QUIT

e.g. s/STR_015E_QUIT_GAME/STR_015F_QUIT_GAME/ and s/STR_015F_QUIT/STR_015G_QUIT/ for all files lang/*.txt

But renaming all those strings in all language files would increase the patch size tremendously. I'll gladly supply such extended patch, if desired.

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2754
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Shouldn't adding 'Load scenario' mean that 'Load heightmap' should be added too? After all, heightmaps can be downloaded in a very similar manner. And shouldn't that then result in adding 'New game' too? If you can do the 'start new game' via heightmap, a new game without heightmap should be possible too.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2754#comment6104

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/2754

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek