Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize box at left-edge of window #2704

Closed
DorpsGek opened this issue Mar 5, 2009 · 1 comment
Closed

Resize box at left-edge of window #2704

DorpsGek opened this issue Mar 5, 2009 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Mar 5, 2009

Alberth opened the ticket and wrote:

Putting a resizebox widget at the lower left corner of a window, and trying to use it gives incorrect results. The window is resized asif the resizebox was at the lower right corner of the window.
These patches fix that problem.

This problem has never been found due to the fact that by convention all resize boxes in OpenTTD are at the lower-right corner of the windows.

01_doxygen_fixes.patch adds two Doxygen strings.
02_resize_left_edge.patch fixes the problem by introducing a _resize_left_edge variable that causes reversal of resizing. It also causes shifting of the whole window.
(moving cursor to the left should not reduce the size of the window, but rather increase it, and at the same time move the left edge by the same amount to give the illusion that the left edge moves and the right edge stays fixed).

For experimenting, I have added a test_case.patch that modifies the small map window.
DO NOT COMMIT that patch to trunk!!

One thing that remains is to render a different sprite in the resize box when attached to the left edge.
I have fought with gimp all evening to get openttdgui.pcx bigger so the sprite can be added, and failed.

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2704
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In changed form in r15760 (with graphics)


This comment was imported from FlySpray: https://bugs.openttd.org/task/2704

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant