Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

land area clearance cost displayed in wrong colour #2438

Closed
DorpsGek opened this issue Dec 5, 2008 · 3 comments
Closed

land area clearance cost displayed in wrong colour #2438

DorpsGek opened this issue Dec 5, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 5, 2008

Alberth opened the ticket and wrote:

revision hea3784c0b3dd (svn r14655)

Money I have to pay is normally displayed in red colour, while money I get is normally displayed in a non-red colour. In the land-area information window, however, the opposite happens because it displays costs.
See attached images.

I can see two approaches to solve this atm. Either by a local tweak in the above window (not sure how, I kind of like the 'cost' idea), or by adding a {COST} currency type of field in the string system that does the reverse of {CURRENCY}, and modify STR_01A5_COST_TO_CLEAR .

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2438
@DorpsGek
Copy link
Member Author

Rubidium wrote:

What about changing the 'cost to clear' with something like 'profit on clearing' when the cost is negative and setdparam-ing the absolute value of the cost.
Just needs a proper string and is probably more clear for the user too; negative costs makes some people go crazy.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2438#comment5138

@DorpsGek
Copy link
Member Author

Alberth wrote:

Good suggestion, I didn't consider having two strings.
Thank you very much.

Attached you will find a patch to fix this problem.
Unfortunately, the colour in STR_01A5_COST_TO_CLEAR had to be modified too.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/2438#comment5140

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r14752.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2438

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek