Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extmidi no longer being compiled #2437

Closed
DorpsGek opened this issue Dec 2, 2008 · 1 comment
Closed

extmidi no longer being compiled #2437

DorpsGek opened this issue Dec 2, 2008 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Dec 2, 2008

cirdan opened the ticket and wrote:

I'm having trouble with midi music in recent nightlies (currently r14648). Music does not play at all, even if it did up to a couple of weeks ago (confirmed working in r14607) with the external midi player. Nothing has changed in my setup (linux) in the interim.

Apparently, extmidi.o is no longer being compiled; it seems that the openttd binary no longer depends on it. I have been able to track this issue to sources.list, particularly to the lines

    \# if DOS
    \# else
            music/extmidi.cpp
    \# end

If I remove the conditional, extmidi.o is again a prerequisite to the final binary and gets compiled. This conditional was introduced in r14636 (DOS port), so something must be wrong with it, as I am clearly not running DOS.

I have taken a cursory look at the configure script and it seems to have code (an awk script, to be precise) to parse source.list. The code is contrived, but it seems to handle a number of conditionals but not
the DOS tag. Could this be the source of the problem? (It seems that '# if DOS' is always succeeding, no matter what the OS.)

On a side note, why is SOURCE_LIST defined at the beginning of configure? It is never used afterwards.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2437
@DorpsGek
Copy link
Member Author

DorpsGek commented Dec 3, 2008

Rubidium closed the ticket.

Reason for closing: Fixed

In r14651.
SOURCE_LIST is used in config.lib which is included in configure.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2437

@DorpsGek DorpsGek closed this as completed Dec 3, 2008
@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Build system labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant