Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 'remove' button when selecting a signal from the signal-gui #2314

Closed
DorpsGek opened this issue Sep 21, 2008 · 3 comments
Closed

Disable 'remove' button when selecting a signal from the signal-gui #2314

DorpsGek opened this issue Sep 21, 2008 · 3 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Alberth opened the ticket and wrote:

With the rail build toolbar open, after pressing 's' and 'r' it is easy to remove a (large) number of signals from the tracks.
In that mode, when a user selects a different signal from the signal GUI, it would be useful to assume that the user wants to place the newly selected signal, and disable 'r' automatically.

Attached file implements this (against revision 14367)

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/2314
@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 9, 2009

Rubidium wrote:

This patch doesn't seem to have any effect in current trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2314#comment6615

@DorpsGek
Copy link
Member Author

Alberth wrote:

The effect is very subtle, but it is still there in r17496.

To demonstrate the purpose of the patch, run a clean trunk.

  1. Enable the signal GUI (advanced settings -> construction -> signals -> Enable the signal GUI: ON
  2. Open the rail toolbar, and lay a few track pieces (or find some in an existing game). Alternatively, hit 'a'.
  3. Click at the 'signals' (the signal GUI opens). Alternatively, hit 's'.
  4. Put down a few signals (or find a few existing ones that are expendable in the game).
  5. Enable the signal removal function by clicking at the bulldozer (the tile highlight turns red). Alternatively, hit 'r'.
  6. Remove a few signals.
    Now you want to place new signals.
  7. Click at an unselected signal in the signal GUI. (The selected one also works, but is less likely as in that case just hitting 'r' will work too.)
  8. Move back to the rail tracks, the tile highlight is still red, and you cannot place signals.
  9. Unselect signal removal (by clicking at the bulldozer or hitting 'r').
  10. Move back to the rail tracks, the tile highlight is white, and you can place the signals at the track.

The patch does step 9 for you while doing step 7, thus eliminating step 8.

I don't think there is any other reason to do step 7 other than wanting to place a signal (or to upgrade to a type of signal).
In both cases, you do not want to remove a signal any more, so you always need to do step 9.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2314#comment6634

@DorpsGek
Copy link
Member Author

michi_cc closed the ticket.

Reason for closing: Implemented

In r24130.


This comment was imported from FlySpray: https://bugs.openttd.org/task/2314

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant