Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo **from** unknown destination #2214

Closed
DorpsGek opened this issue Aug 9, 2008 · 3 comments
Closed

Cargo **from** unknown destination #2214

DorpsGek opened this issue Aug 9, 2008 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Aug 9, 2008

Alberth opened the ticket and wrote:

When a train has cargo from a station that was removed, its cargo window says 'cargo from an unknown destination', which is incorrect (especially when we get paxdest in trunk).
See 'unknown_destination.png'.

To fix, I added a {SRC_STATION} string expansion. This expands to the station name in its argument or to the added string STR_UNKNOWN_SOURCE
See attached patch file.
Also attached a screen shot with the fixed output.

Attachments

Reported version: 0.6.2
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/2214
@DorpsGek
Copy link
Member Author

Rubidium wrote:

This requires modifications to WT2 and I'm not yet 100% sure this is the best solution.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2214#comment4588

@DorpsGek
Copy link
Member Author

Alberth wrote:

No idea what WT2 was. Turned out to be web-translator2. Google is sooo good :)

Another solution could be to change 'unknown destination' to 'unknown station'. That has the advantage of getting rid of the idea of a direction (and also of changing the WT2 maybe).

The big down-side imho is that 'station' is quite specific. We may want to create a 'unknown waypoint' string as well (currently also user of 'unknown destination') and 'unknown roadstop' and unknown 'busstation' are around the corner (didn't verify).
Given that station is invalid, is there any hope that you can retrieve the station-type?

This comment was imported from FlySpray: https://bugs.openttd.org/task/2214#comment4593

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r14298.

This comment was imported from FlySpray: https://bugs.openttd.org/task/2214

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek