FS#2001 - Drag&Draw Terraform

Attached to Project: OpenTTD
Opened by Manuel Wolf (Roujin) - Saturday, 10 May 2008, 00:39 GMT
Last edited by andythenorth (andythenorth) - Monday, 14 August 2017, 20:24 GMT
Type Patch
Category Core
Status Closed
Assigned To andythenorth (andythenorth)
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Votes 0
Private No


[Split off from my terraforming patch]

This adds Drag&Draw behavior to the raise and lower tool in the scenario editor, when size is set to 1.

I've thrown out all the other stuff. And tidied the whole thing up and added comments.
Don't know what to say more, so here's a screenshot.
This task depends upon

Closed by  andythenorth (andythenorth)
Monday, 14 August 2017, 20:24 GMT
Reason for closing:  Won't implement
Additional comments about closing:  Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).
Comment by Manuel Wolf (Roujin) - Saturday, 10 May 2008, 15:37 GMT
Due to the changes in trunk regarding viewport/window stuff, here's an update to the new way of handling stuff in viewport.cpp.

Also threw out some unneeded stuff and applied some coding style.
Comment by Manuel Wolf (Roujin) - Monday, 12 May 2008, 17:32 GMT
Updated. No changes done. Please comment? :/
Comment by Manuel Wolf (Roujin) - Monday, 19 May 2008, 03:00 GMT
Okay, major trunk changes in window code outdated this :D
Going to rewrite it soon'ish... hope it gets more chances when you're done with the window stuff ;)
Comment by Manuel Wolf (Roujin) - Tuesday, 20 May 2008, 11:04 GMT
I have posted my newest approach in combination with a question in the forums here:

It's a major rehaul, I think it is quite clean and understandable now, please do have a look at it and help me :)
Comment by Manuel Wolf (Roujin) - Monday, 26 May 2008, 15:48 GMT
.diff updated to r13265...
Comment by Manuel Wolf (Roujin) - Sunday, 08 June 2008, 11:23 GMT
Here's an update to trunk. Hope you haven't forgotten me...
Comment by Zdeněk Sojka (SmatZ) - Sunday, 22 June 2008, 12:55 GMT

thanks for patches. What do you think about idea to raise/lower to different height? It could be done by dragging or after timeout while satying at the same tile.
Comment by Manuel Wolf (Roujin) - Tuesday, 24 June 2008, 12:23 GMT
There is a problem with that.
If I raise one edge, the mouse cursor might move to another tile due to the changed surface. Now there's one pesky spot where, if multi-height raising were allowed, the mouse cursor would move back and forth between two edges, raising every time, until we have a little mountain. This happens so fast that it's not controllable by the user.

This also won't be prevented by the proposed timeout, because we're not staying at the same tile when that happens, but jump between two tiles.