Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for FS1975 not working #1976

Closed
DorpsGek opened this issue May 2, 2008 · 8 comments
Closed

Fix for FS1975 not working #1976

DorpsGek opened this issue May 2, 2008 · 8 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented May 2, 2008

3iff opened the ticket and wrote:

Nightly 12930 + fix from FS1975 recompiled but doesn't fix the problem.

Simple test with a bus running between 2 stations, on entering station, a manual "goto depot" click is forgotten and road vehicle returns to original station.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1976
@DorpsGek
Copy link
Member Author

DorpsGek commented May 6, 2008

yorick wrote:

It is fixed in r12935, so the nightly r12930 doesn't include that fix. Try it with a newer version.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4070

@DorpsGek
Copy link
Member Author

SmatZ wrote:

I fail to reproduce that. Can you with current nightly, Gary?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4164

@DorpsGek
Copy link
Member Author

3iff wrote:

Tested nightly 13205 and it still fails. Just as the vehicle is entering the station, click its depot button to force a depot visit/service. The vehicle enters the station and then reports 'leaving' to head to the depot, exits the station and then returns to the station having forgotten the depot order.

Savegame not necessary as it's easy to set up two bus stations and a bus to prove the problem.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4165

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Savegame would be useful. To show the problem and to simplify reproduction, debugging and fixing.
Ideally paused in a moment when the vehicle should be sent to a depot.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4170

@DorpsGek
Copy link
Member Author

3iff wrote:

Ok, as requested...savegame enclosed. Nightly 13205 no grfs.

Start game paused, open vehicle 1 window, restart game and control/click depot to force a manual service visit.
Vehicle recognises instruction, enters station (because it's going that way), reports "leaving" and then switches instruction to visit the station again, forgetting the service order.

Hope this helps. PM me if you need more...

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4171

@DorpsGek
Copy link
Member Author

SmatZ wrote:

Thanks. I was testing with drive-thru road stations.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4172

@DorpsGek
Copy link
Member Author

3iff wrote:

Ahh, rarely use drivethroughs, perhaps that's why you weren't seeing the problem. Good luck.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976#comment4173

@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 3, 2008

Belugas closed the ticket.

Reason for closing: Fixed

Seems that r13664, for #2117, did the job.
Requested by Yexo


This comment was imported from FlySpray: https://bugs.openttd.org/task/1976

@DorpsGek DorpsGek closed this as completed Jul 3, 2008
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant