Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doxygen updates, CodeChange rail_gui #1942

Closed
DorpsGek opened this issue Apr 20, 2008 · 4 comments
Closed

doxygen updates, CodeChange rail_gui #1942

DorpsGek opened this issue Apr 20, 2008 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Alberth opened the ticket and wrote:

While examining use of windows, I ended up examining and documenting several files, in particular rail_gui.cpp.
In the latter file, I also saw two small code change opportunities.
First apply doxygen update, then codechange1, then codechange2

Revision: 12790

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1942
@DorpsGek
Copy link
Member Author

Rubidium wrote:

Why not using Axis? Because now you're adding a completely similar enum.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1942#comment3956

@DorpsGek
Copy link
Member Author

Alberth wrote:

Because I didn't know it existed :)
Good suggestion, tnx.

Fixed as requested by updating codechange1 to the attached diff file.
Hunks 1 and 3 in codechange2 have been shifted -9 lines, but my patch still accepts them.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1942#comment3960

@DorpsGek
Copy link
Member Author

Alberth wrote:

Updated patches to new revision

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1942#comment4120

@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 1, 2008

Rubidium closed the ticket.

Reason for closing: Implemented

This comment was imported from FlySpray: https://bugs.openttd.org/task/1942

@DorpsGek DorpsGek closed this as completed Aug 1, 2008
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek