Morloth opened the ticket and wrote:

This patch makes virtually all methods of the NoAI API static, as they should be. There is no reason why most of these methods should be non-static member functions. This makes programming a lot simpler as you can simply call:
AICargo.GetCargoLabel(id);

Instead of:
local cargo = AICargo();
cargo.GetCargoLabel

Additional changes:

* AITile
Changes:
- GetCargoAcceptence and GetCargoProduction now both return a boolean value instead of an integer. The values it would return previously didn't have much meaning (for GetCargoAcceptence, lower then 8 means it isn't accepted, higher is better !?). It would be better if GetCargoProduction would return the total production of all industries around, perhaps something for a subsequent patch.

New methods:
IndustryID GetIndustryID(TileIndex); Returns the id of the industry located on this tile (-1 otherwise)

* AIEngine

New methods:
int32 GetMaxAge(EngineID); This function was already in AIVehicle but could only be called AFTER a vehicle was constructed, as AI has a lot to do with planning you want this information beforehand
Money GetRunningCost(EngineID); Gets the running cost of this vehicle per year

Bram

Attachments

• make_static_12180.patch (82.12 KiB)

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1783