Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug when loading transferred cargo #177

Closed
DorpsGek opened this issue May 18, 2006 · 6 comments
Closed

Bug when loading transferred cargo #177

DorpsGek opened this issue May 18, 2006 · 6 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Tekky opened the ticket and wrote:

In the attached screenshot and savegame, I pick up passengers in Smallville and drop them off ("transfer and leavy empty") in Marctown, so the trains arriving in Marctown can also transport the passengers from Smallville. This works fine if the bus drops the passengers from Smallville in Marctown while there is no train waiting in the station.

However, if a train is already waiting in the station (the trains are set to "Load"), it will still load the passengers from the bus from Smallville, but a split second later the train delivers these passengers from Smallville to the station of Marctown, altough the train is set to "Load". Therefore, the train doesn't transport these passengers from Smallville and I am only paid for the short bus trip from Smallville to Marctown.

I have reproduced this bug in Version 0.4.7 and in the latest nightly build.

Attachments

Reported version: 0.4.7
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/177
@DorpsGek
Copy link
Member Author

Tekky wrote:

This bug report is probably related to bug report #140, although the described symptoms are not quite the same.

@admins: If possible, please correct my typo in the task description (casrgo = cargo). Thanks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/177#comment286

@DorpsGek
Copy link
Member Author

PandaMojo wrote:

Duplicates of this: #251 #218 (which contains a failed patching attempt).

Made a patch which fixes this, and I'm pretty sure this version is finally bug free. Should probably still be proofread though. Patch against R5962 attached - main thing I'm worried about is that I'm modifying v->current_order.flags, but it seems to have the exact desired effect with no ill effects... so this is sane, right? right? hopes

I've tested it against the savegame in this thread and the duplicates, as well as two affected savegames of my own. Works for them all. No idea it's effect on #140 without a savegame to test, though. I'd attempt to reproduce it if my left hand hadn't started hurting.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/177#comment422

@DorpsGek
Copy link
Member Author

PandaMojo wrote:

Now that I remember the correct difference between transfer and transfer + full load, yet again fixed patch (against 5986, tested against all savegames once more, seems to work AOK)

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/177#comment441

@DorpsGek
Copy link
Member Author

TubularBell wrote:

Patch seems to work OK... However, after some time the game crashed ('!invalid string id 0 in GetString') which it didn't do before. Can't say if it's because of something in the patch or just it in the revision I patched...

This comment was imported from FlySpray: https://bugs.openttd.org/task/177#comment475

@DorpsGek
Copy link
Member Author

PandaMojo wrote:

Are you able to reproduce it? What revision was used? I've not experienced this playing with this patch this past week with various revisions.

This comment was imported from FlySpray: https://bugs.openttd.org/task/177#comment477

@DorpsGek
Copy link
Member Author

DorpsGek commented Nov 2, 2006

Darkvater closed the ticket.

Reason for closing: Duplicate

251, please continue there

This comment was imported from FlySpray: https://bugs.openttd.org/task/177

@DorpsGek DorpsGek closed this as completed Nov 2, 2006
@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
This was referenced Apr 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek