Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit unnecessary wires on elrail #1761

Closed
DorpsGek opened this issue Feb 10, 2008 · 4 comments
Closed

Omit unnecessary wires on elrail #1761

DorpsGek opened this issue Feb 10, 2008 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Eddi opened the ticket and wrote:

When unelectrified rail crosses with electrified rail, there are useless wires on the branching side of the switches, this patch makes these wires disappear.

there are some special cases to discuss, when someone makes the elrail deliberately end in the middle of nowhere (i.e. not at the track end, nor at a station), then the wire ends one tile too early

also lost trains may enter an elrail bit that has no catenary drawn

r12066

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1761
@DorpsGek
Copy link
Member Author

Eddi wrote:

fixed the case where all trackbits would be removed, but some cases still need special handling.

IMHO, all those cases are nonsensical track combinations anyway, so i'm not sure if they are worth fixing.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1761#comment3480

@DorpsGek
Copy link
Member Author

Eddi wrote:

there is now a problem with pylon placement in some instances, because it does not take into account masked out bits

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1761#comment3481

@DorpsGek
Copy link
Member Author

Eddi wrote:

i fixed the pylon placement, i think ;)

PCP are the points where wires need support by a pylon, those use the "wirebits"
PPP are the directions which side of the track the pylon is put on, this needs to use the "trackbits"

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1761#comment3486

@DorpsGek
Copy link
Member Author

DorpsGek commented Feb 5, 2009

michi_cc closed the ticket.

Reason for closing: Implemented

In r15347.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1761

@DorpsGek DorpsGek closed this as completed Feb 5, 2009
@DorpsGek DorpsGek added Electrified rails flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek