Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting and filtering in industry directory improved #1622

Closed
DorpsGek opened this issue Jan 5, 2008 · 5 comments
Closed

Sorting and filtering in industry directory improved #1622

DorpsGek opened this issue Jan 5, 2008 · 5 comments
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jan 5, 2008

chu opened the ticket and wrote:

I found that the Industry directory could need a little bit refresh.

At first, those 4 buttons for sorting are very uncommon for ttd. In all other places, there are drop-downs and a direction selector.
So I "copied" the functionality from the station list.

Doing so, I noticed, that it would be very nice to be able to filter out industries producing only some kind of good.
So I "copied" the filter functionality of station list into that window too.

Hopefully this becomes not an other patch to "rot in peace" in this fine tool.
Would be nice, if someone would pay a bit attention to that patch... (because I become a little bit disappointed by submitting patches, which seem not even to be noticed at all... )

Attachments

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1622
@DorpsGek
Copy link
Member Author

DorpsGek commented Jan 7, 2008

Belugas wrote:

I agree with the drop down operations.
I disagree with the cargo rows of buttons.
they should have been placed under the drop down area.
It would allow to make the window narrower, which would be good.

code and code style wise, i think there are more that can be done.
Tabs instead of spaces in gui definition,
Duplication of code that could have been better served by loops,
Lack of comments,

So, it has been noticed.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1622#comment3174

@DorpsGek
Copy link
Member Author

gule wrote:

I have updated this patch. Now it uses dropdown for sort options and also dropdown for filter industries by cargo which they produce.
It is also updated to trunk and to use dropdown widget.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1622#comment3951

@DorpsGek
Copy link
Member Author

Alberth wrote:

See also #2312

This comment was imported from FlySpray: https://bugs.openttd.org/task/1622#comment8291

@DorpsGek
Copy link
Member Author

chu wrote:

Some centuries ago, I submitted the patch for filtering the IndustryDirectoryWindow.

Today I felt, that it was time to update it.

And here you are.

It works the same way, the StationWindow works. Have fun.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/1622#comment8838

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).

This comment was imported from FlySpray: https://bugs.openttd.org/task/1622

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) wontfix patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
This was referenced Apr 6, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek