Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LV4 Refit Sprites in Nightly #1461

Closed
DorpsGek opened this issue Nov 21, 2007 · 15 comments
Closed

Missing LV4 Refit Sprites in Nightly #1461

DorpsGek opened this issue Nov 21, 2007 · 15 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

athanasios opened the ticket and wrote:

Refit sprites for LV4 are not displayed. All refit vehicles display same sprite.
Tested on win32 with new game, only LV4 grf loaded to exclude grf conflicts.

Versions affected: 0.6.0-beta 1 and nightlies after it.

Discussion thread: http://www.tt-forums.net/viewtopic.php?f=31&t=34948

Reported version: 0.6.0-beta1
Operating system: Windows


This issue was imported from FlySpray: https://bugs.openttd.org/task/1461
@DorpsGek
Copy link
Member Author

Belugas wrote:

although it has been verified that it actually works on our side, George, it is reopened.
Now: it would be nice if you could provide grf as well as screenshots of good and bad behaviour


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment2992

@DorpsGek
Copy link
Member Author

George wrote:

the same grf, 2 s different screen shots

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment2993

@DorpsGek
Copy link
Member Author

Rubidium wrote:

For me 11629 works as intended with the provided NewGRF.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment2999

@DorpsGek
Copy link
Member Author

George wrote:

config

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3003

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Can you post a savegame that shows this behaviour?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3009

@DorpsGek
Copy link
Member Author

George wrote:

Do not watch at coal mine like iron ore mines industry - it is a test grf for iron ore mine used, just ignore it. If necessary, I can make a blank game.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3010

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Seems rather like a local configuration problem to me. Anyhow, looks like TTDP disables the NewGRF in that case, so we should too.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3011

@DorpsGek
Copy link
Member Author

George wrote:

Yes, you should. But why does it loading after error? The GRF should be totally disabled (and marked red), doesn't it?

P.S. Yes, reordering files fixes the display problem, but it is rather confusing that GRF with error is still loading.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3014

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Because the persons who have messed with implementing Action 7 did not understand the NewGRF specs completely it did not disable the NewGRF, it just skipped all 'next' sprites. Anyhow... if a NewGRF should be disabled with an error, why don't you use the Action B 'fatal error' that immediately disables the NewGRF instead of relying on yet another piece of NewGRF?

Anyhow, that not-completely-correctly-implemented-Action-7 issue should be solved in the current trunk.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3015

@DorpsGek
Copy link
Member Author

George wrote:

With fatal error you can't load the grf unless you restart TTDp. In current situation you can fix error by disabling ECS files after LV4, so the error is not fatal.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3017

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Anyhow... is it better in today's nightly?


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3029

@DorpsGek
Copy link
Member Author

George wrote:

I loaded the save, got the error as intended, reordered the files (moved LV4 to the end), pressed applay... Error disappeared, but file stayed disabled without reporting a reason for disabling. I supposed it to become enabled :(


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3032

@DorpsGek
Copy link
Member Author

Fragster wrote:

I guess this bug appears not only with LV4... same thing happens with UKRS from Pikkabird

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3033

@DorpsGek
Copy link
Member Author

Rubidium wrote:

Those wagons are different because they are different mineral wagons (they are not equal in length).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461#comment3109

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed


This comment was imported from FlySpray: https://bugs.openttd.org/task/1461

@DorpsGek DorpsGek added flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) Vehicles labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant