FS#1337 - Truncating revision infos

Attached to Project: OpenTTD
Opened by Ammler (Ammler) - Sunday, 14 October 2007, 16:04 GMT
Type Bug
Category Interface
Status Closed
Assigned To Benedikt Br├╝ggemeier (skidd13)
Operating System All
Severity Very Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


The Server page shows not the whole revision info. Maybe thats good for the server list But also for detail page or the login screen on the client.
This task depends upon

Closed by  Benedikt Br├╝ggemeier (skidd13)
Sunday, 14 October 2007, 22:16 GMT
Reason for closing:  Invalid
Additional comments about closing:  (23:46:12) Ammller: /task/1337 <-- could be closed

Closed by user request
Comment by Remko Bijker (Rubidium) - Sunday, 14 October 2007, 19:06 GMT
1) It is doing that by-design; ALL text that is send over the internet (in context of OTTD) is truncated at some point. For revisions it's fairly short, because there's no real reason to make them any longer.
2) Not truncating it causes much more hassle (and possible buffer overflows)
3) Truncating already happens way before it is actually send; clients can even join the server, just because we know about the limitation and have written it to cope with "too long" revision strings
4) It works perfectly OK. Is your revision distinguishable from the rest?
5) Changing it means changing the game network protocol, which makes servers invisible for everyone not running the version that changed the protocol (or something higher) OR makes them not display it correctly, which is what this bug report is about.