Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot clear airport with overflying plane #1249

Closed
DorpsGek opened this issue Sep 23, 2007 · 3 comments
Closed

Cannot clear airport with overflying plane #1249

DorpsGek opened this issue Sep 23, 2007 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

cirdan opened the ticket and wrote:

Airports cannot be cleared when there is a plane overflying the airport, even if the plane is heading for another airport.

In the attached savegame, a plane is flying from airport A (to the northwest) to airport C (to the southeast), and it is about to fly over airport B (which is not even on its schedule). As soon as the plane is over airport B, and as long as it does, the airport cannot be cleared. This has been tested in nightly r11193.

Reported version: trunk
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/1249
@DorpsGek
Copy link
Member Author

cirdan wrote:

Oops, it seems I forgot to attach the savegame. Here it is.

Also, I've been looking into the bug and I think that the problem lies in src/station_cmd.cpp, function RemoveAirport. The code tries to ensure that there are no vehicles in the airport before allowing it to be cleared, but it uses EnsureNoVehicle to do so. The attached patch changes it to EnsureNoVehicleOnGround, and this seems to fix it.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1249#comment2190

@DorpsGek
Copy link
Member Author

cirdan wrote:

All right, I am unable to upload the savegame. Anyway, it is available here:
http://www.tt-forums.net/download.php?id=76331

See also the discussion in the thread:
http://www.tt-forums.net/viewtopic.php?f=33&t=33418&start=20

This comment was imported from FlySpray: https://bugs.openttd.org/task/1249#comment2191

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r11183.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1249

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek