Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doxygen doc patch for news.h and news_gui.cpp + minor bug-fix #1235

Closed
DorpsGek opened this issue Sep 17, 2007 · 1 comment
Closed

doxygen doc patch for news.h and news_gui.cpp + minor bug-fix #1235

DorpsGek opened this issue Sep 17, 2007 · 1 comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

Alberth opened the ticket and wrote:

While examining the source code of news.h and news_gui.cpp I edited existing comment, and added new comment such that doxygen understands it. Attached is the patch.

In addition, I made 3 changes in the code:
- about line 315 news_gui.cpp, I added a NT_END size to the new_items_age[] array to make explicit how its size is determined.
- the array had one less value than number of NT
* values. I added "60" for the NT_GENERAL type (used for towns "chaos due to road reconstruction"). Not sure that this value is good, but it seems like a reasonable value
- about line 512, I have added a "default: NOT_REACHED();" alternative for the switch

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1235
@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Implemented

In r11125.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1235

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant