Rubidium wrote:

The new algorithm is a little glitchy in (at least) the two "biggest" zoom out levels. When you have a 2048x2048 map with lots of towns and even more industries and you zoom out completely, select the industries "view" (the lots of colors view), and you scroll through the minimap a single line (depending on the direction of scroll) is glitchy.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment2205

Romanski wrote:

I assume that by "glitchy" you mean that the towns jump a single pixel up or down. The attached diff fixes this issue.

Attachments

• zoomable_smallmap_v3_r11353.diff (42.67 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment2532

Romanski wrote:

Task 1222 (http://bugs.openttd.org/task/1222) implements zoomable smallmap in a different way:

Better in 54:
+ smooth zooming (some people dislike it but I think it's nice)
+ zoom to arbitrary zoom levels
+ zoom in more than the original, un-zoomable map.
+ smaller change vs. the original code, so easier to verify

Better in 1222:
+ 4x higher resolution when zoomed out (the task 54 patch uses the original smallmap algorithm, which is restricted to drawing the map out of 4x1 pixel blocks)
+ draw towns and industries as dots when zoomed out, to avoid them disappearing altogether
+ zoom in/out at cursor, just like the main map
+ scrolling the wheel quickly will zoom several levels in/out quickly
+ pretty dithering
+ works when paused

Please consider both fairly! :) (disclaimer: obviously I'm the author of 1222; I'm trying to be as objective as I can here; if there is an advantage of task 54 patch which I didn't mention it was not on purpose!)

Smooth scrolling could be implemented on top of this patch if desired, too. I didn't do that in the first revision though because this is quite a big change already.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment2551

TrueBrain wrote:

Without really reading the patch, I have a question for you: is it possible to split up the patch is smaller pieces, as it is really big, and undoable to read all.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment2587

Romanski wrote:

@truelight: I could reduce it to about 90% of its current size by reverting some tidy-ups. The rest is one big change, unfortunately. The diff is unreadable because it is too fine-grained: really it should show a bunch of functions being deleted and replaced with a bunch of other functions.

I don't suppose reducing it to 90% will help you much?

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment2611

Alberth wrote:

Although your patch didn't make it to trunk, it was a source of inspiration. Thank you.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222#comment7537

Alberth closed the ticket.

Reason for closing: Implemented

in r19039-r19042

This comment was imported from FlySpray: https://bugs.openttd.org/task/1222