skidd13 wrote:

I changed the behavior of the patch with railway to get better results.

Please comment. And sorry for the huge ammount of code. ;)

Attachments

• do_not_build_inconnective_roads_r10737.patch (13.05 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1750

skidd13 wrote:

Update again. Reduced diff size and removed some needless code parts.

Attachments

• do_not_build_inconnective_roads_r10749.patch (12.29 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1766

skidd13 wrote:

As requested: Moved the functions from road_map to road.

Attachments

• do_not_build_inconnective_roads_r10750.patch (13.28 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1767

skidd13 wrote:

Update and some cleanups

Attachments

• do_not_build_inconnective_roads_r10765.patch (9.59 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1775

skidd13 wrote:

Fixed the possibility to generate roads with no roadbits. :( sorry for the bug. Thanks to Rubidium for spotting this.

Attachments

• do_not_build_inconnective_roads_r10814.patch (13.69 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1810

skidd13 wrote:

I split off the new bridge generator from the road clean up itself. Hope this makes including the patch easier.

[con]
* more cpu cycles for the town growth
* things build after the roads can still cause unlovely road junctions

[pro]
* visually better road layouts in the towns
* less cpu cycles needed for "pathfinding" to search through the town
* "Found local road construction" has now a positive thing too.

Attachments

• town_road_cleanu_r10850.patch (10.53 KiB)
• town_road_cleanu_new_bridge_gen_r10850.patch (2.75 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1858

skidd13 wrote:

Another update. I think the behavior with roads leading towards water is now better handled (opticaly).

Now it's even harder to split the patch. So I post it uncut.

I could split it into:

1. new functions for road.h (IsPossibleCrossing, MirrorRoadBits, RotateRoadbits CountBits)
2. Function CleanupRoadBits
   2.a) expand "Found local road construction"
   2.b) "Cleanup town roads" at construction stage (Removes also now unneeded calculations of the old algorithm)
3. Improved town bridge behavior (will fix roads leading into water)

It would be nice to hear comments (not only on IRC)

Attachments

• town_road_cleanup_r10926.patch (16.19 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment1884

skidd13 wrote:

Main rewrite of the patch. There a a few things to think about.

- Roads leading into water seem to be a fault of the command. That needs some deeper checking.
- IMO the patch needs 2 new settings: enable global. enable modified road construction.

Attachments

• town_road_cleanup_r11112.patch (13.23 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2125

skidd13 wrote:

Added patch options

Attachments

• town_road_cleanup_r11122.patch (16.89 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2138

skidd13 wrote:

Damn forget to remove some unneeded stuff. Sorry.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2150

skidd13 wrote:

Removed slope checks cause they are unnecessary now.

Attachments

• town_road_cleanup_r11132.patch (15.53 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2169

skidd13 wrote:

Changed some stuff in the BUILD_ROAD command. It's now able to handle one bit on more slopes :)
The cleaner town roads should be fine now.

Attachments

• town_road_cleanup_r11137.patch (22.00 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2182

skidd13 wrote:

Damn forgot to add the road.cpp

Attachments

• road.cpp (1.89 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2183

Rubidium wrote:

+ RoadBits road_bits = pieces | existing;
+
+ / Single bits on slopes.
+ * We check for the roads that need at least 2 bits */
+ if (_patches.build_on_slopes && !_is_old_ai_player &&
+ (COUNTBITS(road_bits) + COUNTBITS(*pieces)) == 2 &&
+ (_valid_tileh_slopes_road[2][tileh] & *pieces) == ROAD_NONE) {
+ return CommandCost(_price.terraform);
+ }
The roadbit counting algorithm looks broken to me. If *pieces has one bit set and there are no existing bits, COUNTBITS(road_bits) + COUNTBITS(*pieces)) == 2 will succeed. Furthermore it will not succeed if existing has two bits set and pieces one bit.

Furthermore the coding style (consistency) is lacking at some places. No spaces after some commas, spaces before semicolons, no newline before the { of a function body and probably more.

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2184

skidd13 wrote:

I hope I fixed all issues.

Attachments

• town_road_cleanup_r11139.patch (25.42 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2185

skidd13 wrote:

Did some cleanup and naming stuff.

Attachments

• town_road_cleanup_r11159.patch (26.12 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090#comment2199

Rubidium closed the ticket.

Reason for closing: Implemented

In r11172

This comment was imported from FlySpray: https://bugs.openttd.org/task/1090