Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

train head and tail move at different speeds when passing a curve #1063

Closed
DorpsGek opened this issue Jul 21, 2007 · 4 comments
Closed

train head and tail move at different speeds when passing a curve #1063

DorpsGek opened this issue Jul 21, 2007 · 4 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Phazorx opened the ticket and wrote:

Can be also described like: while passing a curve train grows by a quarter.

Roots of the issues are in how diagonal tracks are handled by the game - traveled distance and visual length are calculated differently on diagonal tracks and same on straight tracks. For sprite drawing and representation purposes each tile fits 2 standard wagons on straight or diagonal tracks, however, for speed/distatnce calculation it is 2 per for straight tile and 2.5 for diagonal. This becomes more apparent and problematic with longer trains, 20 tile trains (40 cars) would gain extra "5 tiles of drag" by the time it is fully diagonal, and following train in same track would have to stop/slow down.

This affects all releases starting form original TTD, so this is "inherited behavior".

I understan complexity of correcting it to be more realisitc (changing representation part and not using 2 cars per diagonal for drawing purposes) so I'd rather see change on speed/distance part and instead of using a factor of 0.75 for diagonal travel make it 1, matching "visual" ratio.

Attached savegame illustrates the problem

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/1063
@DorpsGek
Copy link
Member Author

Ammler wrote:

As this Problem does not only exists in OpenTTD, It's there since TTO. I attached a Save for the Patch too.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1063#comment1964

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2007

Rubidium wrote:

Fixing this means shortening vehicles, which means:
- 500+ modified vehicle graphics for trunk (different angles, 256 vehicles). If you change the trains, you also have to change the road vehicles, ships and aircraft.
- basically ditching NewGRF support as the basic principle of the game becomes totally different

Furthermore there's the fact that TTD is not designed to have the vehicles run diagonally.

Fixing it the other way around, by increasing the speed of trains won't fix it at all, because you need to accelerate the whole train, which causes the whole train to go even faster on diagonal tracks, which makes even more money.

I just think this is the penalty you have to pay for "cheating" the system into getting your goods quicker at the destination (and thus getting more money).


This comment was imported from FlySpray: https://bugs.openttd.org/task/1063#comment2090

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 7, 2007

Rubidium closed the ticket.

Reason for closing: Won't fix

See last comment.


This comment was imported from FlySpray: https://bugs.openttd.org/task/1063

@DorpsGek DorpsGek closed this as completed Sep 7, 2007
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 8, 2013

bcmpinc wrote:

This patch, based on vanilla openttd, svn revision 25057, fixes this bug by correcting the speed of all wagons, except the head. So the speed of trains remain the same, but they no longer grow and shrink while passing corners.

This patch introduces a new bug. Diagonal train segments will be drawn overlapping. As Remko mentioned, this cannot easily be fixed.

Savegames with/without this patch can be loaded fine without/with this patch, but trains need to be sent through depot to fix the distances between wagons.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/1063#comment12392

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant