Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spectator cannot see list of available vehicles #994

Closed
DorpsGek opened this issue Jul 7, 2007 · 6 comments
Closed

Spectator cannot see list of available vehicles #994

DorpsGek opened this issue Jul 7, 2007 · 6 comments
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 7, 2007

bilbo opened the ticket and wrote:

In r10470, spectator is not able to see list of vehicles (button "Available trains" on train list is missing, same for other vehicle types)

I joined a game with some interesting newGRF to spectate and I was curious what trains are available in the game. However, I was unable to invoke the available vehicle list from the list of company's trains.

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/994
@DorpsGek
Copy link
Member Author

DorpsGek commented Aug 8, 2011

monoid wrote:

This patch allows all users to use the 'available vehicles' buttons.

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/994#comment10166

@DorpsGek
Copy link
Member Author

DorpsGek commented Sep 2, 2017

andythenorth wrote:

Patch fails to apply on r27908

openttd-trunk(master)$ curl https://bugs.openttd.org/task/994/getfile/7662/availveh.diff | patch -p0
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 11545 100 11545 0 0 72965 0 --:--:-- --:--:-- --:--:-- 73069
(Stripping trailing CRs from patch.)
patching file src/autoreplace_gui.cpp
Hunk # 1 FAILED at 29.
Hunk # 2 succeeded at 388 (offset 40 lines).
1 out of 2 hunks FAILED -- saving rejects to file src/autoreplace_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/build_vehicle_gui.cpp
Hunk # 1 succeeded at 890 with fuzz 2 (offset 58 lines).
Hunk # 2 FAILED at 917.
Hunk # 3 FAILED at 948.
Hunk # 4 FAILED at 979.
Hunk # 5 succeeded at 1050 with fuzz 2 (offset 111 lines).
Hunk # 6 succeeded at 1148 (offset 112 lines).
Hunk # 7 succeeded at 1189 with fuzz 2 (offset 113 lines).
Hunk # 8 succeeded at 1208 with fuzz 2 (offset 114 lines).
Hunk # 9 succeeded at 1233 with fuzz 2 (offset 115 lines).
Hunk # 10 FAILED at 1402.
Hunk # 11 succeeded at 1507 (offset 141 lines).
Hunk # 12 succeeded at 1519 (offset 141 lines).
4 out of 12 hunks FAILED -- saving rejects to file src/build_vehicle_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/depot_gui.cpp
Hunk # 1 succeeded at 767 with fuzz 2 (offset 65 lines).
(Stripping trailing CRs from patch.)
patching file src/group_gui.cpp
Hunk # 1 FAILED at 349.
Hunk # 2 FAILED at 480.
2 out of 2 hunks FAILED -- saving rejects to file src/group_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/vehicle_gui.cpp
Hunk # 1 FAILED at 1181.
Hunk # 2 succeeded at 1283 with fuzz 2 (offset 90 lines).
Hunk # 3 FAILED at 1633.
2 out of 3 hunks FAILED -- saving rejects to file src/vehicle_gui.cpp.rej
(Stripping trailing CRs from patch.)
patching file src/vehicle_gui.h
Hunk # 1 succeeded at 44 with fuzz 2 (offset -9 lines).


This comment was imported from FlySpray: https://bugs.openttd.org/task/994#comment14725

@DorpsGek DorpsGek added component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) enhancement labels Apr 6, 2018
@TrueBrain TrueBrain added patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay bug Something isn't working and removed enhancement from FlySpray labels Apr 10, 2018
@andythenorth
Copy link
Contributor

This is not worth fixing imho, just join a company. Or get the grfs from bananas in single-player.

@PeterN
Copy link
Member

PeterN commented May 22, 2018

Available vehicles can differ for each company (literally as spectator there are no vehicles available). I think you also can't see what other companies have available when playing. I'm not sure we want to start exposing details about other companies.

@James103
Copy link
Contributor

Maybe if you click on the 'Available vehicles' button on a company's vehicle list window (even if it's not your company), you can see which vehicles are available for your company, even though it is the other company's vehicle list window.

@andythenorth
Copy link
Contributor

Thanks for this. There's been no activity on this for some time, and as it stands, it doesn't look likely that it will go any further. I'm closing it as we try to keep the issue count low for OpenTTD, it helps us focus on things that are important and fun. Feel free to discuss in irc or request re-opening if you disagree. Thanks for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: interface This is an interface issue flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

5 participants