Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Town Language Change in Scenario Editor #984

Closed
DorpsGek opened this issue Jul 3, 2007 · 2 comments
Closed

Town Language Change in Scenario Editor #984

DorpsGek opened this issue Jul 3, 2007 · 2 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Jul 3, 2007

boekabart opened the ticket and wrote:

I (also) officially suggest this patch for trunk; I've tested it thoroughly, it serves a useful purpose for scenario creators and I think the coding style is ok. So... I'm looking forward to seeing this in trunk soon!

Attachments

Reported version: trunk
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/984
@DorpsGek
Copy link
Member Author

DorpsGek commented Jul 3, 2007

glx wrote:

Fixed this patch so it works with action F grfs.

But I have a question :) As it is only available in scenario editor, why are you using CMD_RENAME_TOWN in RandomTownName()? I think you can directly change t->townname* values like it's done in DoCreateTown().

Attachments


This comment was imported from FlySpray: https://bugs.openttd.org/task/984#comment1525

@DorpsGek
Copy link
Member Author

andythenorth closed the ticket.

Reason for closing: Won't implement

Mass closure of patch tickets with no commentary for >5 years. Goal is to reduce patch queue as an experiment to see if it aids faster reviewing and rejection/acceptance (it may not). If this offends you and the patch is maintained and compiles with current trunk, discuss with andythenorth in irc. (andythenorth has no ability to review patches but can re-open tickets).


This comment was imported from FlySpray: https://bugs.openttd.org/task/984

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) patch from FlySpray This issue is in fact a Patch, but imported from FlySrpay
Projects
None yet
Development

No branches or pull requests

1 participant