TrueBrain wrote:

Any suggestions how to fix it, or what can be done about it? What exactly is 'wrong' about it?

This comment was imported from FlySpray: https://bugs.openttd.org/task/944#comment1856

frosch wrote:

The attached picture shows the differences of elrail-drawing in the different versions.

Current OTTD trunk has the following problems:
* Wires are not connected in corners.
* Wires are not connected with the pylons. Especially visible in corners and vertical track.

The attached patch changes the sprite positions to those of TTDP.
(see svn://svn.ttdpatch.net/trunk/patches/electrif.asm)
TTDP's pylon.x and pylon.y match OTTD's (?_pcp_offsets + ?_ppp_offsets).
TTDP's flatwires and slopewires (columns 2-5) match OTTD's CatenarySpriteData.?_offset and CatenarySpriteData.?_size.

OTTD trunk contains the line "/** Corrects an off-by-one error in some places (tileh 12 and 9) (TODO -- find source of error) */".
This is fixed now. It was caused by determining the Z-height of SW/SE tileedges with tilecoords (15, 8) and (8, 15) instead of (16, 8) and (8, 16). (see changed in ?_pcp_offsets)

The tilecoord 16 makes Z-height determination a bit more complicated. (see comment in attached patch)

Attachments

• ElrailSpritePlacementFix.png (57.07 KiB)
• ElrailSpritePlacementFix_r10977.patch (13.80 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/944#comment1961

Rubidium wrote:

You seem to have removed the (optional) transparancy from the catenary.

This comment was imported from FlySpray: https://bugs.openttd.org/task/944#comment1996

frosch wrote:

Hmm, I broke even more (catenary on bridge ramps).

To recompense I fixed another issue (see attached screenshot).

Attachments

• ElrailSpritePlacementFix_r11015.patch (15.83 KiB)
• AdditionElrailFix.png (14.29 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/944#comment2007

Rubidium closed the ticket.

Reason for closing: Fixed

In r11054. Thanks frosch.

This comment was imported from FlySpray: https://bugs.openttd.org/task/944