Rubidium wrote:

Please check the coding style guideline and remove all the debug stuff that shouldn't be in trunk. Furthermore you should get rid of a lot of the # defines as they make debugging much harder and remove that huge indent by placing it in a helper function or so.

This comment was imported from FlySpray: https://bugs.openttd.org/task/928#comment1456

Ev wrote:

Consider reviewing v0.6.

check the coding style guideline
Had already removed all what i considered not compatible with guideline. Be precise if other remained.

remove all the debug stuff that shouldn't be in trunk
Debug levels used: 5, 6. According to debug.h:
* 5 - detailed debugging information
* 6.. - extremely detailed spamming
See no interfere.

get rid of a lot of the # defines as they make debugging much harder
Macros are programming tool. Will try to say without rudeness: Consider not enforcing other people not to use tool which subject not familiar with.

remove that huge indent by placing it in a helper function or so.
Indent reduced by 8 tabs.

This comment was imported from FlySpray: https://bugs.openttd.org/task/928#comment1464

Ev wrote:

Edit: ...4 tabs.

This comment was imported from FlySpray: https://bugs.openttd.org/task/928#comment1465

Ev wrote:

I removed/simplified some macros where it was possible.

This comment was imported from FlySpray: https://bugs.openttd.org/task/928#comment1472

Ev wrote:

OBSOLETE.

This comment was imported from FlySpray: https://bugs.openttd.org/task/928#comment1478

Rubidium closed the ticket.

Reason for closing: Out of date

This comment was imported from FlySpray: https://bugs.openttd.org/task/928