matze wrote:

Added patch. Sorry for the borked link above.

Attachments

• openttd-ungroup-r10267.patch (21.54 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/915#comment1415

Rubidium wrote:

Putting all vehicles that are not in a "valid" group in the "all" group seems very counterintuitive to me. I would recommend to just use "DEFAULT_GROUP" as way to mark the vehicle as ungrouped.

This comment was imported from FlySpray: https://bugs.openttd.org/task/915#comment1488

matze wrote:

I thought I left that untouched, vehicles not assigned to a group struct are still put in the DEFAULT_GROUP (and ALL_GROUP should never get assigned to a vehicle; maybe I'm misunderstanding all this). Are you referring to these lines in the patch:

Index: src/engine.cpp

--- src/engine.cpp (revision 10267)
+++ src/engine.cpp (working copy)
@@ -490,7 +490,7 @@

  er->to = INVALID_ENGINE;
  er->next = NULL;

- er->group_id = DEFAULT_GROUP;
+ er->group_id = ALL_GROUP;
return er;
}

I replaced the group of the engine replacements for all vehicles by the ALL_GROUP, and use the replacements of DEFAULT_GROUP for vehicles with this group (=ungrouped vehicles). I did the same for the GUI, where DEFAULT_GROUP was used to refer to all vehicles.

Attached updated version (update to r10387 and cleanup, documentation/comments fixed to match changes)

Attachments

• openttd-ungroup-r10387.patch (17.58 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/915#comment1504

Rubidium closed the ticket.

Reason for closing: Implemented

In r10567

This comment was imported from FlySpray: https://bugs.openttd.org/task/915