SmatZ opened the ticket and wrote:

in CheckTrainCollision(), train crashes after the first match
It may cause desync as all players may have different order of vehicles in the hash table

Another problem, crashing only one train is not correct - when you move the uncrashed train, it crashes immediatelly if you set them correctly.

This patch causes that all trains that should crash, crash.

How to cause desync:
see attached file - build tracks, then trains 1,2,3
Let train 2 go to its place, then train 1
Later, let train 3 crash them.
Players that connected after you prepared trains 1,2 will get disconnected.

When used at a public server, you may connect at the beginning of the game, then connect after few years crash trains and disconnect everyone (however they may connect back)

(this patch was discussed at # openttd )

Attachments

• crashes3.diff (3.25 KiB)

Reported version: 0.5.2
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/892