Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't raise/lower land with diagonal rails with certain slopes #882

Closed
DorpsGek opened this issue Jun 17, 2007 · 3 comments
Closed

Can't raise/lower land with diagonal rails with certain slopes #882

DorpsGek opened this issue Jun 17, 2007 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

oxygene opened the ticket and wrote:

Please see the attached image. It is possible to terraform towards a situation with a N, E, S or W slopes only but no way out of it without having to rebuild the rail.
The reason for this behavior seems to lie in clear_cmd.cpp in the function TerraformProc. There is an array of "unsafe slopes" and a comment about a bug that needs to be avoided. However, I don't understand why these would be unsafe. I've removed the check and could not find any unexpected situations.

Please tell me if I miss something.

Attachments

Reported version: 0.5.2
Operating system: All


This issue was imported from FlySpray: https://bugs.openttd.org/task/882
@DorpsGek
Copy link
Member Author

Rubidium wrote:

What's (probaly) meant that "unsafe slopes" are slopes where the slope of the foundation changes when terraforming occurs, which is, by the way, implemented badly in this case.


This comment was imported from FlySpray: https://bugs.openttd.org/task/882#comment1384

@DorpsGek
Copy link
Member Author

oxygene wrote:

Well, the question is what the expected behavior is. However, either all 4 cases in the PNG should fail or succeed. (I'm pleading for succeeding)


This comment was imported from FlySpray: https://bugs.openttd.org/task/882#comment1385

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r10219.


This comment was imported from FlySpray: https://bugs.openttd.org/task/882

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Development

No branches or pull requests

1 participant