FS#88 - Automatically Build Semaphores before a set year

Attached to Project: OpenTTD
Opened by thepizzaking (thepizzaking) - Wednesday, 29 March 2006, 08:00 GMT
Last edited by Bjarni (Bjarni) - Sunday, 20 August 2006, 19:55 GMT
Type Patch
Category Core
Status Closed
Assigned To No-one
Operating System All
Severity Low
Priority Normal
Reported Version trunk
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No


This patch I made allows Automatic building of Semaphores before a chosen year.
Default is 1975, but can be set anywhere from 1920 to 2015 (if it is above 2010 they are always built)
This makes normal placing signals build semaphores instead of light signals, if you *REALLY* want light signals you can Ctrl+click.
I'd like to know what you think.
(Patch against r4143)
This task depends upon

Closed by  Jonathan Coome (Maedhros)
Monday, 15 January 2007, 22:38 GMT
Reason for closing:  Implemented
Additional comments about closing:  This feature has been added in r8151, but in a slightly different way so that each player can choose their settings individually.
Comment by thepizzaking (thepizzaking) - Friday, 07 April 2006, 23:05 GMT
New version against the latest SVN (r4317)
Comment by thepizzaking (thepizzaking) - Thursday, 13 April 2006, 08:01 GMT
Update to latest SVN (r4408)
Also fix the internal documentation which I forgot to change after my testing.
Comment by thepizzaking (thepizzaking) - Sunday, 16 April 2006, 10:15 GMT
Update to r4444
Just because it looks cool
Comment by thepizzaking (thepizzaking) - Sunday, 23 April 2006, 00:07 GMT
Update to r4536
Comment by thepizzaking (thepizzaking) - Thursday, 04 May 2006, 12:18 GMT
Update to r4734
Comment by thepizzaking (thepizzaking) - Tuesday, 30 May 2006, 06:14 GMT
Another update, r5024
Comment by Darkvater (Darkvater) - Thursday, 02 November 2006, 20:43 GMT
The question is if we want the functionality to be player-based, or server-based.

Yours is server-based; eg whatever the server decides happens,  FS#114  is player-based.
Comment by thepizzaking (thepizzaking) - Thursday, 02 November 2006, 21:54 GMT
You will notice that  FS#114  has been incorrectly implemented. It is set up so that it inverses the control press before 1950, so if you want to change pre built signals to one-way signals you have to press control. If you don't press control it will turn them into pre-signals.
Comment by Darkvater (Darkvater) - Thursday, 02 November 2006, 22:33 GMT
Yes, could be; didn't look that closely. The question remains however how we want the signals: enforced by server or set by each player's liking.

There is also a third option, which would be a mix of these two meaning that a semaphore built for user A could be a signal for user B in an MP game but I will not even consider this an option. Technically this would be correct because the signal is really eyecandy so nothing will go "wrong" if it's switched.
Comment by thepizzaking (thepizzaking) - Tuesday, 26 December 2006, 04:09 GMT
Just updated it to the latese revison. (r7559)