SmatZ wrote:

Well, atm it needs to solve problem with overtaking, if you have not done it yet. Really, I didn't mean to subscribe it officially yet.

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1308

SmatZ wrote:

Honestly, I am not happy you took my patch, did some changes and subscribed it here without consultation with me. I mentioned there is a problem with vehicle overtaking that must be solved, so why are you so in hurry with publishing?

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1309

madman2003 wrote:

Could you describe the problem, because road vehicles do overtake as far as i can see.

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1310

madman2003 wrote:

Sorry for this, consider this patch withdrawn, until this problem is solved.

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1311

madman2003 wrote:

This should fix the problem with buses, the problem is that the new hash map does not include results from nearby tiles, so i added that in the RoadVehFindCloseTo() function.

@smatz: does this solve your problems too?

Attachments

• gui_modified_r10081.patch (12.08 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1314

SmatZ wrote:

Strange you didn't encounter problems with overtaking, it happens very often. See attached file.
Patch shouldn't be commited until RoadVehController() is digged into and all possible problems are solved!

What I really dislike about it now: you took the unfinished patch, did some changes without understanding how the code works, and published it here.
I think you should give me some recommendations instead of doing messy updates and publishing the patch, with you as the publisher.

(you invited problems by removing 'ssign=false', by changes in 'UpdateVehiclePosHash()')
Well, I could comment code better, but I didn't mean to publish it yet.
(anyway, the changes you made seem obviously problematic for me - maybe you could comment them to make it clear they won't invite eg. vehicles in corners of viewport not drawn?)

Please, wait until I submit my patch, and then submit your updates. You can help me with the patch, but not this way!
Sadly, I do not have time to spend writing code atm.

Attachments

• Setfingburg Transport, 11th Jan 1950.sav (88.01 KiB)

This comment was imported from FlySpray: https://bugs.openttd.org/task/853#comment1315

Rubidium closed the ticket.

Reason for closing: Out of date

Something else with the same (or even better) characteristics has been committed to trunk (r10111).

This comment was imported from FlySpray: https://bugs.openttd.org/task/853