Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ships not passing buoy (maybe YAPF) #736

Closed
DorpsGek opened this issue Apr 17, 2007 · 15 comments
Closed

Ships not passing buoy (maybe YAPF) #736

DorpsGek opened this issue Apr 17, 2007 · 15 comments
Labels
component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

Desolator opened the ticket and wrote:

I'm using the Town Layout patch for r9623, which has nothing to do with the ships as far as I saw when applying it to compile win32 binaries. The ships won't go past that buoy, for no apparent reason. It looks like the buoy is stopping them from passing like a wall, but it can also be a YAPF bug. In the zip file there are the config file, the newgrfs I use, a screenshot, and a saved game. The binaries can be gotten from here: http://www.tt-forums.net/download.php?id=69014

I haven't tested this with the latest revision, since the saved games aren't compatible with the trunk. I hope this will help.

Reported version: trunk
Operating system: Windows

This issue was imported from FlySpray: https://bugs.openttd.org/task/736
@DorpsGek
Copy link
Member Author

KUDr wrote:

  1. Please try tp reproduce it on last nightly or trunk without patches
  2. Try it without "Use YAPF for ships"
  3. Let me know the result
  4. In case that it will be reproducible upload savegame that reproduces it and is compatible with trunk

thanks
KUDr

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1146

@DorpsGek
Copy link
Member Author

Desolator wrote:

Well I don't think I can reproduce it in latest trunk, I'll ask the creator of the patch to sync it with the latest revision. For now, I'll try it with YAPF disabled.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1147

@DorpsGek
Copy link
Member Author

Desolator wrote:

It works with YAPF disabled. I guess it's a YAPF bug, though it may be fixed in newer revisions.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1148

@DorpsGek
Copy link
Member Author

KUDr wrote:

Thanks, will look at it

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1149

@DorpsGek
Copy link
Member Author

Desolator wrote:

The weird stuff it the ships pass the other buoys to that one, where they will get stuck.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1150

@DorpsGek
Copy link
Member Author

KUDr wrote:

The savegame is not usable/loadable. Can you please upload some trunk compatible savegame that reproduces the problem? Here it seems to work. Thanks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1151

@DorpsGek
Copy link
Member Author

Desolator wrote:

The developer of the patch has updated it, I'll compile it and test the saved game. If the bug is still there, I'll upload the game and post the link.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1152

@DorpsGek
Copy link
Member Author

KUDr wrote:

Forget the patch. Try to reproduce it on trunk version. Please...

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1153

@DorpsGek
Copy link
Member Author

Desolator wrote:

Not so easy, I can't get the saved game load in the trunk because of the bump. I'll do my best though.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1154

@DorpsGek
Copy link
Member Author

KUDr wrote:

Yes, but you know how you can reproduce it. So simply start new game and try. I can't repro it and your savegames don't help me either. So only what I can do now is to close the bug with "Works for me" reason.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1155

@DorpsGek
Copy link
Member Author

Desolator wrote:

I haven't got it like on the savegame, but those ships seem to be stuck there with no apparent reason. Works on NPF. http://rapidshare.com/files/26923544/on_r9677.zip

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1156

@DorpsGek
Copy link
Member Author

KUDr wrote:

Look, I belive you that there is a bug in YAPF, but I cannot fix if it works in supported versions of OTTD. YAPF is called from ship controller and it uses many other parts of game (map accessors, orders, etc.). Any error in those related parts can lead to the wrong behavior. Therefore I can't support every custom patch and need your help reproducing it with trunk or release version for which that I can get sources from our SVN. I need to compile it in debug mode, run it under debugger and analyze what is wrong there. This cannot be done on custom game binaries. If you want me to fix it please help me to reproduce it on such OTTD version. Thanks.

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1157

@DorpsGek
Copy link
Member Author

Desolator wrote:

So revision 9677 which I got from http://www.openttd.org/nightly.php isn't good? I just downloaded it, copied the TDD GRFs and the NewGRFs I use and popped up the game, used all the cheats, built a funky layout and boom, ships get stuck in a buoy when trying to go in a straight way to the dock which is pretty close!

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1158

@DorpsGek
Copy link
Member Author

KUDr wrote:

Sorry. It was misunderstanding on my side. I didn't know that your last savegame (inside on_r9677.zip) was that one I am looking for (unpatched). Now I have what I need (reproducible case) so can finally try to fix it. Thanks

This comment was imported from FlySpray: https://bugs.openttd.org/task/736#comment1159

@DorpsGek
Copy link
Member Author

KUDr closed the ticket.

Reason for closing: Fixed

r9694 /trunk/src/yapf/yapf_ship.cpp (2007-04-20 19:19:23 UTC)
-Fix [YAPF][#736]: the guessed path (when PF stopped on max. # of nodes passed) was ignored for ships (desolator)

This comment was imported from FlySpray: https://bugs.openttd.org/task/736

@DorpsGek DorpsGek added component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) bug labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: pathfinder This issue is related to Pathfinder flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek