Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

64bit<->32bit money conversion bugs #723

Closed
DorpsGek opened this issue Apr 8, 2007 · 9 comments
Closed

64bit<->32bit money conversion bugs #723

DorpsGek opened this issue Apr 8, 2007 · 9 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

DorpsGek commented Apr 8, 2007

HMage opened the ticket and wrote:

The 64-bit money value is being truncated in many places into a negative value, as a result, some features become unavailable, others misbehave.

* If you have more than signed 32bit value of money, you're not allowed to send money to another player, says 'you're not allowed to send loaned money'
* If you try to build something that costs too much, either you're not allowed to do that, or you get income, or there's an error message when the requested action was done correctly, or the action isn't done completely.

Attachments

Reported version: 0.5.0
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/723
@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 8, 2007

HMage wrote:

I must apologize, but I didn't fill correct data for openttd version.

This report is for nightly, revision 9570. If it's possible could anyone fix this? I can't.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1132

@DorpsGek
Copy link
Member Author

ewanm89 wrote:

Could you create a save without all the NewGRF files loaded please?

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1221

@DorpsGek
Copy link
Member Author

qery wrote:

just connect to any network game which is about year 3000 any youll see it yourself

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1244

@DorpsGek
Copy link
Member Author

ewanm89 wrote:

Accept I'm testing against current svn, there aren't usually any current svn servers (compatibility checking stops different versions joining), let alone ones that are year 3000.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1245

@DorpsGek
Copy link
Member Author

qery wrote:

i have a save game if you want (0.5.1) year 2681.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1246

@DorpsGek
Copy link
Member Author

Belugas wrote:

Just for the record, we are aware of that "bug". It needs a different method of handling the amounts internally. It will be addressed, but not in the near future. I've already started an attempt, but it is a long and tedious process. All versions of OpenTTD are "poised" with that problem. If anyone wants to try and solve the problem, i've included my attempt, which is still a big WIP and WILL NOT COMPILE. Just to show a possible road. Feel free to expand it

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1247

@DorpsGek
Copy link
Member Author

ewanm89 wrote:

Thanks guys, I'm looking into it also.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1248

@DorpsGek
Copy link
Member Author

ewanm89 wrote:

Could someone set status to confirmed then.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723#comment1249

@DorpsGek
Copy link
Member Author

Rubidium closed the ticket.

Reason for closing: Fixed

In r10212.

This comment was imported from FlySpray: https://bugs.openttd.org/task/723

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
This was referenced Apr 6, 2018
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek