Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid last_vehicle for station (crash) #71

Closed
DorpsGek opened this issue Mar 12, 2006 · 3 comments
Closed

Invalid last_vehicle for station (crash) #71

DorpsGek opened this issue Mar 12, 2006 · 3 comments
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)

Comments

@DorpsGek
Copy link
Member

jayson.barker opened the ticket and wrote:

This save game was saved from my openttd server, the server is running Fedora core 4, with openttd 0.4.5 running in dedicated server mode, all clients who connected to it crashed. I saved the game and opened it localy, and it still crashes. I have attached the savegame incase it is any use to you.

Reported version: 0.4.5
Operating system: All

This issue was imported from FlySpray: https://bugs.openttd.org/task/71
@DorpsGek
Copy link
Member Author

Darkvater wrote:

On updating the station ratings the station's last vehicle is an invalid one (st->last_vehicle).
There is no functionality in the code for handling situations with a station where the last vehicle has been already deleted.

I propose not storing last_vehicle but only the last vehicle type to fix this problem. As far as I can see from the code, only GetVehicle(st->last_vehicle)->type is used.

This comment was imported from FlySpray: https://bugs.openttd.org/task/71#comment137

@DorpsGek
Copy link
Member Author

DorpsGek commented Apr 6, 2006

Celestar wrote:

Here's a diff to solve the problem.

Attachments

This comment was imported from FlySpray: https://bugs.openttd.org/task/71#comment168

@DorpsGek
Copy link
Member Author

Celestar closed the ticket.

Reason for closing: Fixed

This comment was imported from FlySpray: https://bugs.openttd.org/task/71

@DorpsGek DorpsGek added Core flyspray This issue is imported from FlySpray (https://bugs.openttd.org/) labels Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flyspray This issue is imported from FlySpray (https://bugs.openttd.org/)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DorpsGek